Skip to content

Mypy fix #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

Mypy fix #158

merged 1 commit into from
Mar 8, 2023

Conversation

@domendobnikar
Copy link
Collaborator

@domendobnikar domendobnikar commented Mar 8, 2023

Use Optional[] instead of Union[] where necessary.

justinc1
justinc1 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better :)

@domendobnikar domendobnikar merged commit aeb4eab into main Mar 8, 2023
@domendobnikar domendobnikar deleted the annotation-fix branch March 8, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinc1 justinc1 justinc1 approved these changes

@PolonaM PolonaM PolonaM approved these changes

@anazobec anazobec anazobec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@domendobnikar @justinc1 @PolonaM @anazobec